updated node usb native from vscode-arduino repo - #194
Conversation
|
NOTE: this change is just copy+pasting the changes from the vscode-arduino repo (https://github.com/microsoft/vscode-arduino/tree/master/vendor/node-usb-native). Any comments about the code should be directed towards that team 😯 |
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
LGTM.
Just FYI, if this is a straight copy from the other repository, it might be worth considering using git submodules.
Vandy Liu (vandyliu)
left a comment
There was a problem hiding this comment.
good stuff drea
David Serafimov (@nasadigital) |
Thanks for looking into it! |
Description:
The CPX serial monitor for deploy to device currently doesn't work, even on the extension published to the VS Code Marketplace. It seemed that the issue was that the code in the ./vendor/ directory was outdated. This code is taken from the vscode-arduino repository and it seems like there was a fix from 3 months ago to fix a bug. Otherwise, that code was untouched for ~ 3yrs.
See here: https://github.com/microsoft/vscode-arduino/tree/master/vendor/node-usb-native
Type of change
Limitations:
Testing:
Checklist:
npm run formatand passes the checks innpm run check