This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Display module for microbit library - #189
Merged
Merged
Conversation
Vandy Liu (vandyliu)
requested review from
Ahmed Mahdy (abmahdy),
Andrew Clements (adclements),
Jennifer Davis (iennae) and
Isa (isadorasophia)
as code owners
February 4, 2020 19:06
Andrea Mah (andreamah)
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Thanks for figuring this all out 😎
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
Great job on making this faithful to the device! 👍
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
Thanks for applying the fixes! Just a bit more~
added 2 commits
February 6, 2020 12:26
David Serafimov (nasadigital)
approved these changes
Feb 6, 2020
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
Just address the last comment and LGTM! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implemented the display module for the microbit library.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check