This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Port JSX type checking - #762
Merged
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Copilot and
Jake Bailey (jakebailey)
and removed request for
Copilot
April 7, 2025 18:44
Contributor
There was a problem hiding this comment.
Copilot reviewed 1733 out of 1738 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.symbols: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.types: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.types.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/callsOnComplexSignatures.js.diff: Language not supported
Comments suppressed due to low confidence (1)
internal/compiler/program.go:164
- Ensure that tspath.ExtensionTsx is included in tspath.SupportedJSExtensionsFlat (or handled separately) if TSX files are intended to be supported. Otherwise, TSX files may inadvertently be excluded from the unsupportedExtensions list.
if slices.Contains(tspath.SupportedJSExtensionsFlat, extension) {
Jake Bailey (jakebailey)
approved these changes
Apr 7, 2025
Member
|
Basically impossible to review this on any website at all, I was barely able to click approve 😄 The error baseline thing is fixed in #763. I also wish |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 7, 2025
Jake Bailey (jakebailey)
approved these changes
Apr 7, 2025
|
History in the making... thank you, Anders Hejlsberg (@ahejlsberg)! |
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.