Fix ClassCleanup not called when the first test in class is ignored - #5070
Merged
Youssef Fahmy (Youssef1313) merged 3 commits intoFeb 19, 2025
Merged
Youssef Fahmy (Youssef1313) merged 3 commits into
Youssef Fahmy (Youssef1313) merged 3 commits into
Conversation
Member
Author
|
/backport to rel/3.8 |
Contributor
|
Started backporting to rel/3.8: https://github.com/microsoft/testfx/actions/runs/13408191594 |
Amaury Levé (Evangelink)
previously approved these changes
Feb 19, 2025
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Suggesting a comment on the test so we don't change order without noticing impact
…eTests.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Amaury Levé (Evangelink)
approved these changes
Feb 19, 2025
Youssef Fahmy (Youssef1313)
enabled auto-merge (squash)
February 19, 2025 08:52
This was referenced Jul 22, 2025
This was referenced Jul 13, 2026
This was referenced Aug 2, 2026
This was referenced Aug 9, 2026
This was referenced Aug 21, 2026
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first test of a class is ignored (and the first test ever in the assembly), we will not call AssemblyInitialize, so
IsAssemblyInitializeExecutedwill be false.However, in that case, we still want to call
RunClassCleanupso that the test is marked as completed (seeMarkTestComplete). Not marking the ignored test as completed is problematic, because later on when all tests in the class are executed, we will still be viewing remaining tests in the class, hence we will not call class cleanup.Note that even with this change, we respect the case where all tests in class are ignored, and we will not call ClassCleanup. The logic in
ExecuteClassCleanuphandles the case when class init wasn't called.Fixes #5062