Add PreferAssertFailOverAlwaysFalseConditionsAnalyzer - #2799
Merged
Amaury Levé (Evangelink) merged 4 commits intoMay 3, 2024
Merged
Conversation
Youssef Fahmy (Youssef1313)
force-pushed
the
always-false-analyzer
branch
from
May 3, 2024 06:54
01a4f2b to
2fec7c0
Compare
Youssef Fahmy (Youssef1313)
force-pushed
the
always-false-analyzer
branch
from
May 3, 2024 07:10
2fec7c0 to
7744f15
Compare
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Nice to see you here Youssef Fahmy (@Youssef1313)! I added a few comments/nits
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Member
Author
Thank you! and thanks for the review! I addressed the review comments and updated testsbaseline.txt. Let's see if CI will be green now. |
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
May 3, 2024 10:52
Amaury Levé (Evangelink)
approved these changes
May 3, 2024
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution Youssef Fahmy (@Youssef1313) 
This was referenced Jul 22, 2025
This was referenced Jul 29, 2025
Closed
This was referenced Oct 29, 2025
This was referenced Nov 5, 2025
This was referenced Nov 12, 2025
This was referenced Nov 19, 2025
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2753