Repository navigation
internal/safeopen: fix strings.Contains args order - #469
Merged
Merged
Conversation
The following (old) code:
strings.Contains(":", path)
Only returns true if path is ":" or an empty string.
This is not what was intended.
The proper ":" check is:
strings.Contains(path, ":")
Found by using new go-critic linter check.
Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
John Howard (lowenna)
left a comment
Contributor
There was a problem hiding this comment.
Nice find. Seems the right thing to me. Joe Terry (@jterry) WDYT? I think the intention was as per this change, but haven’t dug or verified.
Contributor
|
This was for sure a bug. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following (old) code:
Only returns true if path is ":" or an empty string.
This is not what was intended.
The proper ":" check is:
Found by using new go-critic linter check.
Signed-off-by: Iskander Sharipov quasilyte@gmail.com