Don't require grapheme boundaries - #970
Merged
Merged
Conversation
Leonard Hecker (lhecker)
enabled auto-merge (squash)
October 1, 2026 16:25
Comment on lines
+107
to
+108
| let rest = | ||
| if rest.is_empty() { self.doc.read_forward(self.offset + 1) } else { rest }; |
Member
Author
There was a problem hiding this comment.
The fix.
| self.offset += self.chunk.len(); | ||
| self.chunk = self.doc.read_forward(self.offset); | ||
| self.chunk_off = 0; | ||
| self.read(); |
Member
Author
There was a problem hiding this comment.
Remove duplicate code.
| // We can rely on the fact that the document does not split graphemes across chunks. | ||
| // = If there's a newline it's wholly contained in this chunk. | ||
| if self.chunk_off > 0 && self.chunk[self.chunk_off - 1] == b'\n' { | ||
| if self.chunk.get(self.chunk_off.wrapping_sub(1)) == Some(&b'\n') { |
Member
Author
There was a problem hiding this comment.
The compiler can't know that self.chunk_off < self.chunk.len() so this conditional .get() access helps it avoid panics.
Dustin L. Howett (DHowett)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting a lone CR in front of a LF in a document,
it joins to form a single grapheme cluster (CRLF) but
the gap buffer will split the grapheme into two chunks.
This commit fixes navigation across such chunks.