This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Repository navigation
Update title bar button styles to match the minimize/maximize/close buttons - #3243
Merged
Merged
Conversation
Tim Kurtzman (timkur)
requested review from
andreww-msft,
Jason Holmes (jaholme) and
Zarana Kiran Desai (zadesai)
June 17, 2024 20:45
Jason Holmes (jaholme)
approved these changes
Jun 17, 2024
|
|
||
|
|
||
| <StackPanel x:Name="AllControls" Orientation="Vertical" Grid.Row="1" HorizontalAlignment="Center" Margin="0" Background="Transparent"> | ||
| <StackPanel x:Name="AllControls" Orientation="Vertical" Grid.Row="0" HorizontalAlignment="Center" Margin="0" Background="Transparent" Spacing="5"> |
Contributor
There was a problem hiding this comment.
nit: Grid.Row/Column=0 is the default, so explicitly setting it is redundant.
andreww-msft
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Updates the ChromeButton style to better match the minimize/maximize buttons
References and relevant issues
Detailed description of the pull request / Additional comments
Before
After
The background coloring is different compared to the minimize/maximize buttons, but I'm pretty sure the WindowCaptionButtonBackgroundPointerOver and WindowCaptionButtonBackgroundPressed are the values to use.
This also flattens the layout in the vertical bar a little more as well. I still went with the "chrome button" style in the vertical orientation, though I think it's valid to ask why those buttons look different than the other buttons in that layout.
Validation steps performed
PR checklist