Sitelet https://github.com/microsoft/component-detection/pull/72
Skip to content

Strong-name the assemblies - #72

Closed
David Federman (dfederm) wants to merge 4 commits into
microsoft:mainfrom
dfederm:strong-naming
Closed

Strong-name the assemblies#72
David Federman (dfederm) wants to merge 4 commits into
microsoft:mainfrom
dfederm:strong-naming

Conversation

@dfederm

@dfederm David Federman (dfederm) commented Feb 28, 2022

Copy link
Copy Markdown
Member

This strong-names the assemblies so that applications which are themselves strong-named can use these libraries.

The snk file was generated by running: sn -k StrongName.snk

@dfederm
David Federman (dfederm) requested a review from a team as a code owner February 28, 2022 21:24
@JamieMagee

Jamie Magee (JamieMagee) commented Mar 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

David Federman (@dfederm) Are we okay to still merge this, even if we're blocked with upstream dependencies?

EDIT: Nope! Moving this to draft for now.

@JamieMagee
Jamie Magee (JamieMagee) marked this pull request as draft March 29, 2022 20:53
@cobya Coby Allred (cobya) added version:major status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality) labels Jun 14, 2022
@JamieMagee

Jamie Magee (JamieMagee) commented Jun 29, 2022

Copy link
Copy Markdown
Member

I opened a PR upstream dotnet/Docker.DotNet#567

@JamieMagee

Jamie Magee (JamieMagee) commented Jan 4, 2023

Copy link
Copy Markdown
Member

PR merged upstream. Waiting for a release now.

@JamieMagee

Jamie Magee (JamieMagee) commented Mar 1, 2023

Copy link
Copy Markdown
Member

Version 3.125.13 was released upstream with the required strong-naming 🎉

@JamieMagee

Jamie Magee (JamieMagee) commented Mar 1, 2023

Copy link
Copy Markdown
Member

See #453

@JamieMagee

Jamie Magee (JamieMagee) commented Mar 1, 2023

Copy link
Copy Markdown
Member

David Federman (@dfederm) can you rebase this branch please? I don't have permissions to push to your fork, but I've created a branch you can reset to: strong-naming.

We're getting closer, but the build still fails due to a lack of strong named assemblies for Tomlyn and Valleysoft.DockerfileModel. I've created issues upstream:

I'll also create pull requests when I have time.

@FernandoRojo

Fernando Rojo (FernandoRojo) commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

Closing for now as unneeded, but we can revisit if there is more need for strong-naming in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FernandoRojo Fernando Rojo (FernandoRojo) Awaiting requested review from FernandoRojo FernandoRojo is a code owner automatically assigned from microsoft/ose-component-detection-maintainers
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality) version:major

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dfederm @JamieMagee @FernandoRojo @cobya