test(agentchat): cover streaming cancellation cleanup - #8093
Open
nightcityblade wants to merge 1 commit into
Open
test(agentchat): cover streaming cancellation cleanup#8093nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Contributor
|
nightcityblade please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
AssistantAgent streaming cancellation did not have deterministic coverage for a model stream blocked on pending work. This adds a regression test that cancels the stream, verifies the consumer terminates before any late chunk is emitted, and confirms the linked pending task and async generator are cleaned up.
Related issue number
Closes #8092
Checks
Local validation:
pytest packages/autogen-agentchat/tests/test_assistant_agent.py -q(89 passed, 3 skipped)ruff checkandruff format --checkmypyon the changed test modulepoe pyrighttask (0 errors)