fix(grpc): support signal shutdown on Windows - #8082
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
GrpcWorkerAgentRuntime.stop_when_signal()currently callsloop.add_signal_handler()unconditionally. The default Windows event loop does not implement that API, so cross-language workers fail withNotImplementedErrorinstead of waiting for shutdown. The gRPC host has the same signal-registration path.This change keeps native asyncio signal handlers on supported event loops and falls back to
signal.signal()when the event-loop API is unavailable. The fallback schedules shutdown on the owning loop withcall_soon_threadsafe, and both paths remove or restore their handlers when waiting finishes. A shared helper keeps worker and host behavior consistent.Related issue number
Closes #5760
Checks
Local validation:
pytest -q python/packages/autogen-ext/tests/test_grpc_signal_utils.py— 2 passed on WindowsAI assistance: Codex was used to inspect the failing paths, implement the fix, and run the checks above. The final diff and test behavior were reviewed before submission.