fix: preserve MessageFilterAgent chronological order - #8075
Open
Zhewen Tan (tandede) wants to merge 1 commit into
Open
fix: preserve MessageFilterAgent chronological order#8075Zhewen Tan (tandede) wants to merge 1 commit into
Zhewen Tan (tandede) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
MessageFilterAgentselected the correct messages for each source, but concatenated those selections inper_sourceconfiguration order. When source messages were interleaved, the wrapped agent therefore received a scrambled conversation timeline.This change retains each selected message's original index and restores chronological order after all per-source filters have been applied. The existing first/last/count selection behavior remains unchanged.
A regression test reproduces the documented looping-agent case where a prior response from B must remain before A's newer revision.
Related issue number
Closes #7971
Checks
Test plan
poe --directory packages/autogen-agentchat fmt(65 files unchanged)poe --directory packages/autogen-agentchat lintpoe --directory packages/autogen-agentchat mypy(64 source files checked)poe --directory packages/autogen-agentchat pyright(0 errors)poe --directory packages/autogen-agentchat test(377 passed, 5 skipped)