Account for type parameters in missing function codefix - #49727
Merged
Nathan Shively-Sanders (sandersn) merged 10 commits intoJul 26, 2022
Merged
Nathan Shively-Sanders (sandersn) merged 10 commits into
Nathan Shively-Sanders (sandersn) merged 10 commits into
Conversation
Josh Goldberg ✨ (JoshuaKGoldberg)
force-pushed
the
codefix-missing-function-generic
branch
from
June 29, 2022 16:29
107164d to
e157bff
Compare
Josh Goldberg ✨ (JoshuaKGoldberg)
marked this pull request as ready for review
June 29, 2022 16:47
Nathan Shively-Sanders (sandersn)
requested changes
Jul 18, 2022
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Initial comments, although I still need to read getArgumentTypesAndTypeParameters more closely
5 tasks done
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Josh Goldberg ✨ (JoshuaKGoldberg)
marked this pull request as draft
July 22, 2022 22:32
Josh Goldberg ✨ (JoshuaKGoldberg)
marked this pull request as ready for review
July 24, 2022 14:35
Josh Goldberg ✨ (JoshuaKGoldberg)
requested a review
from Nathan Shively-Sanders (sandersn)
July 24, 2022 14:35
Nathan Shively-Sanders (sandersn)
approved these changes
Jul 26, 2022
Josh Goldberg ✨ (JoshuaKGoldberg)
deleted the
codefix-missing-function-generic
branch
July 26, 2022 22:22
Josh Goldberg ✨ (JoshuaKGoldberg)
restored the
codefix-missing-function-generic
branch
August 8, 2022 04:30
Josh Goldberg ✨ (JoshuaKGoldberg)
deleted the
codefix-missing-function-generic
branch
August 9, 2022 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to any explicit type parameters, also accounts for any type parameters in the types of arguments.
I noticed both callers ofEdit: no longer true as of #50004. Reverted.typeToAutoImportableTypeNodeusechecker.getBaseTypeOfLiteralType, so I deduplicated & moved that inside the function.Fixes #49693