[Macro] Fix macro cancellation, learning, and approval bugs - #3128
Open
George Ng (GeorgeNgMsft) wants to merge 3 commits into
Open
George Ng (GeorgeNgMsft) wants to merge 3 commits into
George Ng (GeorgeNgMsft) wants to merge 3 commits into
Conversation
Revalidate staged grammar at approval, preserve open object inputs, and allocate lifecycle versions above pending immutable drafts. Follow up on #3118 without changing NFA refresh. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
George Ng (GeorgeNgMsft)
marked this pull request as draft
October 2, 2026 21:24
Require a current approved source when publishing learning adaptations. Keep identical saved drafts idempotent without changing the catalog, and recheck source provenance during approval and recovery. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Hillary Mutisya (hillary-mutisya)
approved these changes
Oct 2, 2026
George Ng (GeorgeNgMsft)
marked this pull request as ready for review
October 3, 2026 00:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #3118 and fixes five problems with recording, learning, and approving reusable macros. It makes cancellation stop unfinished learning, fixes cases where valid recordings or inputs were rejected, and prevents approval or disable operations from leaving conflicting or inconsistent macros behind.
Regression tests cover these scenarios, and the related documentation is updated. The build, all 210 targeted tests, formatting, and repository quality checks passed locally. Hosted CI and live model/tool execution were not part of those local checks.
NFA grammar refresh is intentionally not included. Approving a macro still does not grant permission to execute its tools.