Repository navigation
Adding StopSpeaking() to TextToSpeechManager - #338
Merged
Merged
Conversation
|
Is there a test scene where you can call this function? |
Contributor
Author
|
You bet 😜 I forgot to add it before. Which also reminded me of a previous Issue about passing the AudioSource's IsPlaying through via an IsSpeaking method. I had to manually track that, and actually there's a bug in my test scene...fix incoming... |
Contributor
Author
|
Fix is in |
| /// Stops text-to-speech playback. | ||
| /// </summary> | ||
| public void StopSpeaking() | ||
| { |
There was a problem hiding this comment.
Nit: should this be if(IsSpeaking())
Contributor
Author
There was a problem hiding this comment.
Yeah, that'd make the code more concise! Incoming...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested here (and I think this is useful!): https://forums.hololens.com/discussion/3107/how-do-i-stop-the-tts-from-speaking-in-the-holotoolkit?
Checks to see if the AudioSource is playing and, if it is, stops it. This allows the user to cancel TTS playback mid-stream, without having to keep track of the AudioSource outside TextToSpeechManager.