[202x][0004] Remove interface keyword - #8995
Open
Chris B (llvm-beanz) wants to merge 2 commits into
Open
Chris B (llvm-beanz) wants to merge 2 commits into
Chris B (llvm-beanz) wants to merge 2 commits into
Conversation
TC57 has decided not to include `interface` support in the official standard for HLSL. This change removes the feature in HLSL 202x and issues a warning diagnostic in the hlsl-2026-compat group to enable users to identify issues before they move to HLSL 2026. Resolves microsoft#8481 Assisted-by: GitHub Copilot
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The release note incorrectly limits the compatibility warning to HLSL 2021.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes interface from HLSL 202x while providing migration diagnostics for earlier versions.
Changes:
- Marks
interfaceas removed in HLSL 202x. - Adds compatibility warnings and tests.
- Documents the language change.
| File | Description |
|---|---|
tools/clang/test/SemaHLSL/removed-keywords-202x.hlsl |
Tests 202x behavior. |
tools/clang/test/SemaHLSL/removed-keywords-2026-warnings.hlsl |
Tests compatibility warnings. |
tools/clang/lib/Parse/ParseDecl.cpp |
Emits the deprecation warning. |
tools/clang/include/clang/Basic/TokenKinds.def |
Marks interface as removed. |
tools/clang/include/clang/Basic/DiagnosticCommonKinds.td |
Defines the warning diagnostic. |
docs/ReleaseNotes.md |
Documents the removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated release notes to reflect changes in HLSL 202x compatibility and features. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC57 has decided not to include
interfacesupport in the official standard for HLSL. This change removes the feature in HLSL 202x and issues a warning diagnostic in the hlsl-2026-compat group to enable users to identify issues before they move to HLSL 2026.Resolves #8481
Assisted-by: GitHub Copilot