Converted all samples to use AgilitySDK 1.618.3 - #932
Merged
alecardoso-tech merged 33 commits intoNov 11, 2025
Merged
alecardoso-tech merged 33 commits into
alecardoso-tech merged 33 commits into
Conversation
alecardoso-tech
requested review from
amarpMSFT and
Copilot
and removed request for
Copilot
November 11, 2025 00:58
There was a problem hiding this comment.
Pull Request Overview
This PR converts multiple D3D12 samples to use AgilitySDK version 1.618.3, replacing the previous approach of including d3dx12.h locally. The changes add NuGet package references for Microsoft.Direct3D.D3D12 (version 1.618.3), export SDK version symbols, and include various code quality fixes.
Key Changes:
- Addition of Microsoft.Direct3D.D3D12 NuGet package (version 1.618.3) to all samples
- Removal of local d3dx12.h header file references
- Export of D3D12SDKVersion (618) and D3D12SDKPath symbols for Agility SDK
- Update of WinPixEventRuntime package version
- Code quality improvements (type conversions, function calls)
Reviewed Changes
Copilot reviewed 177 out of 203 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages.config files | Added Microsoft.Direct3D.D3D12 v1.618.3 package reference |
| .vcxproj files | Added NuGet import statements and validation targets |
| .vcxproj.filters files | Removed d3dx12.h from project filters |
| Source .cpp files | Added SDK version exports and code fixes |
| D3D12RaytracingSakuraForestSER | Updated DirectXTK/DirectXTex dependencies, fixed type conversions |
| D3D12RaytracingOpacityMicromaps | Updated package versions, fixed XMVectorSet calls |
| D3D12Multithreading | Fixed pow/powf function call |
| D3D12nBodyGravity | Fixed sqrt/sqrtf function call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amarpMSFT
requested changes
Nov 11, 2025
| </PropertyGroup> | ||
| <Error Condition="!Exists('..\packages\Microsoft.Direct3D.D3D12.1.715.0-preview\build\native\Microsoft.Direct3D.D3D12.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Direct3D.D3D12.1.715.0-preview\build\native\Microsoft.Direct3D.D3D12.props'))" /> | ||
| <Error Condition="!Exists('..\packages\Microsoft.Direct3D.D3D12.1.715.0-preview\build\native\Microsoft.Direct3D.D3D12.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Direct3D.D3D12.1.715.0-preview\build\native\Microsoft.Direct3D.D3D12.targets'))" /> | ||
| <Error Condition="!Exists('..\packages\Microsoft.Direct3D.DXC.1.8.2404.55-mesh-nodes-preview\build\native\Microsoft.Direct3D.DXC.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Direct3D.DXC.1.8.2404.55-mesh-nodes-preview\build\native\Microsoft.Direct3D.DXC.props'))" /> |
Contributor
There was a problem hiding this comment.
samples that use preview sdks should not be changed.
Contributor
There was a problem hiding this comment.
there are probably other examples, this is just one that I noticed.
Contributor
Author
There was a problem hiding this comment.
Reverted changes from all the samples that use preview nuget packages
vdwtanner
reviewed
Nov 11, 2025
vdwtanner
approved these changes
Nov 11, 2025
amarpMSFT
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted all samples to use AgilitySDK 1.618.3
List of samples converted: