Fixed the DXR samples so they can run on (I'm wheezing) Surface Book 3. - #676
Merged
Merged
Conversation
…3 and other MSHybrid systems.
|
|
Contributor
Author
|
TL;DR on the CLA, code is in the public domain glhf. |
Chuck Walbourn (walbourn)
suggested changes
Nov 27, 2020
| { | ||
| throw exception("DXGI 1.6 not supported"); | ||
| } | ||
| for (UINT adapterID = 0; DXGI_ERROR_NOT_FOUND != factory6->EnumAdapterByGpuPreference(adapterID, DXGI_GPU_PREFERENCE_HIGH_PERFORMANCE, IID_PPV_ARGS(&adapter)); ++adapterID) |
Contributor
There was a problem hiding this comment.
There was a recent fix to make this a little more robust. Change this:
DXGI_ERROR_NOT_FOUND != m_dxgiFactory->EnumAdapters1(adapterID, &adapter); ++adapterID)
to
SUCCEEDED(m_dxgiFactory->EnumAdapters1(adapterID, &adapter); ++adapterID))
Contributor
Author
There was a problem hiding this comment.
That would definitely be an improvement, I'm only fixing one thing at (my own) time though, I don't think I will spend more time on this unless the core functionality of making it work on MSHybrid systems has issues.
Contributor
Author
|
I signed the CLA, should be merge-able as-is now. |
Contributor
Author
|
Ping - any blockers on this? |
Member
|
I'll update adapter enumeration code for the DXR samples to bring it in line with the other samples. |
|
Have at Ye! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the DXR samples so they can run on (I'm wheezing) Surface Book 3 and other MSHybrid systems.