Sitelet https://github.com/microsoft/ApplicationInsights-dotnet-server/issues/750#issue-275655423
Skip to content
This repository was archived by the owner on Jul 5, 2020. It is now read-only.
This repository was archived by the owner on Jul 5, 2020. It is now read-only.

Mistake on SyntheticUserAgentTelemetryInitializer.cs #750

Closed
Closed
Mistake on SyntheticUserAgentTelemetryInitializer.cs#750
Labels
bug
Milestone
2.5-Beta2

Description

@christopheMeudec
Christophe Meudec (christopheMeudec)
opened on Nov 21, 2017

Hi,

I found a mistake by reading the code.
https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/ddbd67d40a36ec257990dc0c6e277fc226f1a9d4/Src/Web/Web.Shared.Net/SyntheticUserAgentTelemetryInitializer.cs#L62-L63

The check "request != null" have to be done before accessing to the property UserAgent.

Regards
Christophe

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions