Conversation
pi8027
commented
Jun 3, 2026
|
|
||
| Lemma horner_sum I (r : seq I) (P : pred I) F x : | ||
| (\sum_(i <- r | P i) F i).[x] = \sum_(i <- r | P i) (F i).[x]. | ||
| Proof. exact: (raddf_sum (horner_eval _)). Qed. |
Member
Author
There was a problem hiding this comment.
exact: raddf_sum or rewrite raddf_sum does not work here (tested with Rocq 9.1). Is this a bug of Rocq?
Contributor
There was a problem hiding this comment.
I'll try to have a look at some point during the summer (can't really promise when)
Member
Author
There was a problem hiding this comment.
@proux01 No hurry. I believe that this is a low-priority issue (at least for MathComp).
pi8027
marked this pull request as draft
June 3, 2026 22:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to the Rocq reference manual, we should be able to declare canonical instances on
(fun ... => key ...).This change requires math-comp/hierarchy-builder#594.
Minimal TODO list
doc/changelog/make-entry.shSee this Checklist for details.
Automatic note to reviewers
Read this Checklist.