Use binary parser for rat Number Notation - #1602
Draft
hoheinzollern wants to merge 1 commit into
Draft
hoheinzollern wants to merge 1 commit into
hoheinzollern wants to merge 1 commit into
Conversation
proux01
reviewed
May 28, 2026
| (* (c) Copyright 2006-2016 Microsoft Corporation and Inria. *) | ||
| (* Distributed under the terms of CeCILL-B. *) | ||
| From HB Require Import structures. | ||
| From Corelib Require Import PosDef. |
Contributor
There was a problem hiding this comment.
We may not want to go to binary N or Z, keeping the value behind a locked Decimal -> rat should be enough.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes slow parsing of large rational numbers. Vibe-coded, needs proper review and discussion.
Minimal TODO list
doc/changelog/make-entry.shSee this Checklist for details.
Automatic note to reviewers
Read this Checklist.