Lock form_of_matrix - #1519
Merged
Merged
Lock form_of_matrix#1519
Conversation
proux01
commented
Jan 14, 2026
proux01
left a comment
Contributor
Author
There was a problem hiding this comment.
CI seems happy but we should bench this (and open the two HB issues) before merging.
Comment on lines
-274
to
-281
| (* | ||
| (** | ||
| TODO: bug report | ||
| we were expecting | ||
| without the lock we were expecting | ||
| HB.instance Definition _ n := Bilinear.on (@dotmx n). | ||
| to be sufficient to equip dotmx with the bilinear structure | ||
| but needed to use .copy in the end as in: | ||
| *) | ||
| HB.instance Definition _ n := Bilinear.copy (@dotmx n) dotmx_def. |
Contributor
Author
There was a problem hiding this comment.
We should understand what's happening here and do the bug report.
Comment on lines
+282
to
+296
| TODO: feature request | ||
| implement copy modulo lock | ||
|
|
||
| Lemma dotmx_bilinear n : isBilinear _ _ _ _ *%R (conjC \; *%R) (@dotmx C n). | ||
| Proof. | ||
| rewrite unlock; constructor => /= ?. | ||
| - exact: linearBl. | ||
| - exact: linearBr. | ||
| - exact: linearZl_LR. | ||
| - exact: linearZr_LR. | ||
| Qed. | ||
| HB.instance Definition _ n := dotmx_bilinear n. | ||
| **) | ||
|
|
||
| HB.instance Definition _ n := Bilinear.copy (@dotmx C n) (@dotmx C n). |
Contributor
Author
There was a problem hiding this comment.
We should open the HB issue and remove that comment before merging.
7 tasks
CohenCyril
approved these changes
Feb 27, 2026
Contributor
Author
|
@CohenCyril this could be worth a changelog entry maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted out of #1338
Minimal TODO list
doc/changelog/make-entry.shadded corresponding documentation in the headersSee this Checklist for details.
Automatic note to reviewers
Read this Checklist.