Adapt mxpoly.v to semimodules, semialgebras, and semilinear functions - #1269
Merged
Merged
Conversation
pi8027
force-pushed
the
semi-module-instances
branch
2 times, most recently
from
September 16, 2024 07:32
064de22 to
b2cb08c
Compare
Member
Author
|
Generalizing the results in |
pi8027
force-pushed
the
semi-module-instances
branch
5 times, most recently
from
September 19, 2024 22:09
bc7c750 to
977f8db
Compare
pi8027
force-pushed
the
semi-module-instances
branch
2 times, most recently
from
November 18, 2024 15:00
22eed1a to
5bb43b9
Compare
pi8027
force-pushed
the
semi-module-instances
branch
6 times, most recently
from
March 18, 2025 14:09
c12c458 to
42ceafb
Compare
pi8027
force-pushed
the
semi-module-instances
branch
2 times, most recently
from
March 19, 2025 16:54
b76d91a to
6995082
Compare
3 tasks done
pi8027
force-pushed
the
semi-module-instances
branch
from
April 2, 2025 16:09
6995082 to
fc9c0f4
Compare
pi8027
force-pushed
the
semi-module-instances
branch
from
April 4, 2025 13:14
fc9c0f4 to
58e7fb5
Compare
This was referenced Apr 4, 2025
Member
Author
|
I will cut this PR into smaller pieces. The |
pi8027
force-pushed
the
semi-module-instances
branch
from
April 4, 2025 22:02
58e7fb5 to
c037230
Compare
pi8027
force-pushed
the
semi-module-instances
branch
2 times, most recently
from
April 8, 2025 09:14
1af343a to
69f2c8b
Compare
pi8027
force-pushed
the
semi-module-instances
branch
from
June 19, 2025 16:36
69f2c8b to
68e8ab8
Compare
pi8027
force-pushed
the
semi-module-instances
branch
from
July 25, 2025 12:03
68e8ab8 to
bc3f2af
Compare
pi8027
force-pushed
the
semi-module-instances
branch
from
September 15, 2025 12:10
bc3f2af to
2a7cf44
Compare
pi8027
marked this pull request as ready for review
September 15, 2025 12:11
pi8027
commented
Sep 15, 2025
pi8027
force-pushed
the
semi-module-instances
branch
from
September 16, 2025 12:50
2a7cf44 to
5d1fc1a
Compare
pi8027
force-pushed
the
semi-module-instances
branch
from
September 16, 2025 14:36
5d1fc1a to
33a2f58
Compare
proux01
approved these changes
Sep 17, 2025
proux01
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the CI failure is unrelated, let's merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR generalizes some results in matrix.v and mxpoly.v to the "semi" case using #1125.
Dependencies
Minimal TODO list
doc/changelog/make-entry.sh[ ] added corresponding documentation in the headersSee this Checklist for details.
Automatic note to reviewers
Read this Checklist.