Pagination Fix - #70
Merged
Merged
Conversation
sante85
approved these changes
Jul 9, 2019
Author
|
Is there an estimate of when this change will be merged into the master branch? |
Collaborator
|
I ll review tiday
Il Lun 29 Lug 2019, 19:13 Isaac Leal <notifications@github.com> ha scritto:
… Is there an estimate of when this change will be merged into the master
branch?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#70?email_source=notifications&email_token=ADLHTN6CBXSUBZ2BRWDZBI3QB4QKZA5CNFSM4H45XMFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BMBLQ#issuecomment-516079790>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLHTN3MRTMOZAA7FUZE2CTQB4QKZANCNFSM4H45XMFA>
.
|
Author
|
Any news about the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replaces of self_uri were using static strings.
If the endpoints has no projections or when the sel_uri is a search result, the replace fail and generate a invalid uri.
To fix that I changed the replaces to use regex.
I also fix the uri parameters replace to properly work when the target parameter is the last parameter on the uri.
Examples of uris: this.self_uri = this.self_uri.replace('{?page,size,sort,projection}', '');
"https://localhost:8080/entity{?page,size,sort}"
"https://localhost:8080/entity/search/findByName{?name}"