Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Usage and Regular Expressions code blocks redeclare
let bazandconst named, preventing them from parsing. The Deno examples also request a default export even though the linked source exposes namedparseandinjectexports.Use distinct bindings, add the regular-expression example's namespace import, and use namespace imports in the Deno alternatives. Also align the optional-wildcard pattern comment with default strict matching and remove the outdated parser-only/string-only statement.
Validation: read
src/index.js,index.d.tsand package entry points; checked the regex-building branches statically. Both original code blocks fail Node syntax checking for duplicate declarations, while the corrected blocks passnode --check --input-type=module. No snippets or repository code were evaluated, no imports or CDN URLs were resolved, and the project suite was not run. Only the README changes.Prepared with AI assistance (OpenAI Codex), with source and diff review.