Possible fix for #149 - #188
Conversation
|
I think the reason the rpath was not touched if set already in linuxdeployqt is that too many assumptions were made while this was implemented. The only reason linuxdeploy does this this way is because linuxdeployqt does, too. I do not think it makes sense to just ignore the We should instead try to add (prepend/append) |
|
Main reason of this PR is to fix gstreamer plugin that is broken now. It's happened, because linuxdeploy override rpath that gstreamer-plugin set. And, maybe, it's a fix for #149.
Done. |
| return false; | ||
|
|
||
| d->setElfRPathOperations[sharedLibrary] = "$ORIGIN"; | ||
| auto rpath = elf_file::ElfFile(sharedLibrary).getRPath(); |
There was a problem hiding this comment.
Please make these vars const. Otherwise, this looks really good, thanks!
Co-authored-by: TheAssassin <theassassin@assassinate-you.net>
|
Thanks! |
No description provided.