TPT-4623: Add databases and vpc OAuth scopes - #734
Open
zliang-akamai wants to merge 2 commits into
Open
Conversation
zliang-akamai
requested review from
ezilber-akamai and
psnoch-akamai
and removed request for
a team
August 24, 2026 18:18
Contributor
There was a problem hiding this comment.
Pull request overview
Adds OAuth scope support for Managed Databases and VPC resources.
Changes:
- Adds and registers
OAuthScopes.DatabasesandOAuthScopes.VPC. - Adds unit tests for parsing the new scopes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Summary |
|---|---|
linode_api4/login_client.py |
Defines and registers the new scope families; documentation should clarify that VPC has no read_only grant. |
test/unit/login_client_test.py |
Tests parsing; coverage for generate_login_url serialization and wildcard forms is still needed. |
Suppressed comments (1)
linode_api4/login_client.py:283
- The new test exercises only
parse, not the__repr__values thatOAuthScopes.serializepasses togenerate_login_url. A typo in either new scope string would therefore still pass this suite while producing an invalid authorization request; please add coverage for serialization (preferably throughgenerate_login_url) for the Databases and VPC variants.
def __repr__(self):
if self.name == "all":
return "databases:*"
return "databases:{}".format(self.name)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
OAuthScopesdid not model the documenteddatabasesandvpcscopes, so apps could not request those grants throughgenerate_login_urland tokens that already included them parsed as unknown.This adds
OAuthScopes.Databases(read_only,read_write,all) andOAuthScopes.VPC(read_write,all). VPC has noread_onlygrant.✔️ How to Test