Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
Angular canary compatibility warningThe advisory Angular canary compatibility check failed. This does not block the PR because canary targets are outside the currently required support matrix. Supported peer range:
Stable Angular compatibility rows remain required and will still fail CI if the declared peer range is broken. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Portable Text recreated embedded child views on updates. Visual editing set dynamic component inputs and subscribed to outputs manually, and live preview had two initialization paths. Image URLs with a height could override an explicit
fitchoice.No linked issue.
What is the new behavior?
NgTemplateOutlet, preserving custom descendant component instances across parent updates.inputBindingandoutputBindingfor dynamic visual editing components, reflect input metadata for aliases, and schedule overlay DOM reads and writes withafterRenderEffect.linkedSignal, reuse template signal values with@let, and derive router navigation state withtoSignal.fit, and defer noncritical example content.Does this PR introduce a breaking change?
No public entry point or Angular peer-version range changes.
Other information
Validated after rebasing onto
origin/main:pnpm test— passed (94 library tests, 55 release-tools tests, 27 compatibility tests).pnpm lint— passed.pnpm build— passed.pnpm compat:assert,pnpm compat:release-parity, andpnpm compat:pack— passed.PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/Users/alfonso-andres/Library/Caches/ms-playwright/chromium-1169/chrome-mac/Chromium.app/Contents/MacOS/Chromium pnpm compat:test --set angular-20-floor— passed the Angular 20.0.7 consumer build and Chromium runtime smoke. The installed browser was used because Playwright 1.44.1's browser download stalled locally.SANITY_E2E_BROWSER_CHANNEL=chrome pnpm --filter sanity-presentation-e2e e2e— 3 passed, 2 real Studio tests skipped by configuration.SANITY_E2E_BROWSER_CHANNEL=chrome pnpm --filter sanity-presentation-e2e e2e-studio— 1 hermetic Studio test passed, 1 real Sanity mutation test skipped by configuration.TURBO_SCM_BASE=origin/main pnpm turbo run build test --affected --force— passed after isolating the navigation spec (6 tasks, no cache).pnpm --filter @limitless-angular/sanity lintandgit diff --check— passed.git diff --check origin/main...HEAD— passed.node apps/sanity-presentation-e2e/scripts/sanity-seed-post.mjs— passed; ensured the real smoke document exists.SANITY_E2E_BROWSER_CHANNEL=chrome pnpm --filter sanity-presentation-e2e e2e-real-studio— 2 passed against the real Sanity project, including a live document mutation, preview update without iframe reload, and restoration of the original title.The reverted component-inlining experiment is absent from this PR.
[Optional] What gif best describes this PR or how it makes you feel?
N/A