fix(sanity): remove lodash-es deep imports - #78
Merged
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
osnoser1
force-pushed
the
osnoser1/remove-lodash-es-deep-imports
branch
from
June 20, 2026 03:16
9018cf3 to
c3d1e03
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes N/A
What is the new behavior?
lodash-esdependency from@limitless-angular/sanity.lodash-es/isEqualdeep imports with the existingdequaldependency, so the published FESM no longer ships the extensionlesslodash-es/isEqualimport that fails in some Vitest/Node-side consumer setups.memoizeusage with a small localmemoizehelper that preserves the one-argument reference-cache behavior used by the services.@types/lodash-es.Does this PR introduce a breaking change?
Other information
This fixes a consumer-side Vitest/Node ESM resolution issue caused by the previous extensionless
lodash-es/isEqualimport in@limitless-angular/sanity/preview-kit.Testing:
pnpm --filter @limitless-angular/sanity test -- portabletext/src/utils/memoize.spec.ts preview-kit/src/live-query-provider/live-queries.service.spec.tspnpm --filter @limitless-angular/sanity buildpnpm --filter @limitless-angular/sanity lint[Optional] What gif best describes this PR or how it makes you feel?
N/A