fix(image-loader): update sanity image urls on input changes - #75
Merged
Merged
Conversation
osnoser1
force-pushed
the
osnoser1/image-directive-url-inputs
branch
from
June 18, 2026 01:20
da4a56b to
4711e9f
Compare
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Adds focused coverage and behavior fixes for
SanityImageURL generation when inputs that affect the generated Sanity URL change.Closes #
N/A
What is the new behavior?
ngSrcandloaderParamsthrough directive metadata instead of subclass field redeclarations.ngSrcwhensanityImage,loaderParams,quality,width, orheightchanges.NgOptimizedImageinput changes after synthesizingngSrc, so the underlying optimized image directive receives the URL update without throwing for Sanity-specific recomputation.Does this PR introduce a breaking change?
Other information
Validation run:
corepack pnpm --filter @limitless-angular/sanity test corepack pnpm --filter @limitless-angular/sanity build corepack pnpm --filter @limitless-angular/sanity lint git diff --checkThis PR is stacked on
osnoser1/angular-22-supportso the Angular 22 migration branch can stay limited to the minimal compatibility workaround.[Optional] What gif best describes this PR or how it makes you feel?
N/A