fix(sanity): preserve Angular 18 template compatibility - #64
Merged
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
@limitless-angular/sanitydeclared Angular 18 support, but the published visual-editing entry point included@letsyntax that Angular 18.0.x consumers cannot compile.Closes #
N/A - no linked issue.
What is the new behavior?
The visual editing insert menu and context menu templates now use
@if (...; as icon)aliases instead of@let, preserving the rendered icon behavior while keeping the package compatible with the Angular 18 compiler floor promised by the peer dependency range.The generated Angular compatibility consumer now covers the public Angular component surfaces more deliberately:
ng-template, forcing Angular floor consumers to compile/link those component templates without changing runtime smoke behavior.Does this PR introduce a breaking change?
Other information
Testing:
rg -n "@let" packages/sanitypnpm --filter @limitless-angular/sanity buildpnpm --filter @limitless-angular/sanity testpnpm run compat:packpnpm run compat:test --set angular-18-floor --skip-runtimenode --test tools/angular-compat/*.test.mjspnpm run compat:test --set angular-18-floorgit diff --checkNegative verification:
@let icon = iconFor(schemaType)inVisualEditingInsertMenuComponent, ranpnpm run compat:pack, then confirmedpnpm run compat:test --set angular-18-floor --skip-runtimefailed under Angular 18.0.7 withIncomplete block "let icon". The temporary source edit was reverted and the clean artifact was repacked before the final passing run.Screenshots: N/A - no intended visual change.
[Optional] What gif best describes this PR or how it makes you feel?