Sitelet https://github.com/limitless-angular/limitless-angular/pull/31
Skip to content

fix: pin pnpm engine node version - #31

Merged
osnoser1 merged 1 commit into
mainfrom
osnoser1/fix-pnpm-node-version
Jun 7, 2026
Merged

osnoser1 merged 1 commit into
mainfrom
osnoser1/fix-pnpm-node-version

Conversation

@osnoser1

@osnoser1 osnoser1 commented Jun 7, 2026

Copy link
Copy Markdown
Member

PR Checklist

Closes #

Setup can fail when pnpm install --frozen-lockfile is launched under Node v24.11.0, because @netlify/angular-runtime@4.0.0 requires ^22.22.0 || ^24.13.1 || >=26.0.0 and this workspace has engineStrict: true.

What is the new behavior?

Adds nodeVersion: 22.22.3 to pnpm-workspace.yaml so pnpm evaluates package engine compatibility against the same Node version already pinned by .nvmrc and Volta.

Validated with:

  • pnpm install --frozen-lockfile
  • full local setup script contents from the selected Codex environment
  • full setup path with PATH forced to prefer Node v24.11.0 and Homebrew pnpm
  • git diff --check

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is a local-environment repair only. No dependencies or lockfile entries changed.

[Optional] What gif best describes this PR or how it makes you feel?

@netlify

netlify Bot commented Jun 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit cca76e5
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a25bb46e2b3420008b01f96

@pkg-pr-new

pkg-pr-new Bot commented Jun 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@31

commit: cca76e5

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Angular canary compatibility warning

The advisory Angular canary compatibility check failed. This does not block the PR because canary targets are outside the currently required support matrix.

Supported peer range: ^18.0.0 || ^19.0.0
Workflow run: CI #236

Canary set Target Tested versions First failure
angular-next Angular next Angular 22.0.0, CLI 22.0.0, TypeScript 6.0.3 ✘ [ERROR] TS5101: Option 'baseUrl' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.

Stable Angular compatibility rows remain required and will still fail CI if the declared peer range is broken.

@osnoser1
osnoser1 marked this pull request as ready for review June 7, 2026 18:51
@osnoser1
osnoser1 merged commit b3707ff into main Jun 7, 2026
15 checks passed
@osnoser1
osnoser1 deleted the osnoser1/fix-pnpm-node-version branch June 7, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant