feat(sanity): add angular compatibility harness - #27
Merged
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
osnoser1
marked this pull request as ready for review
June 7, 2026 06:19
Angular canary compatibility warningThe advisory Angular canary compatibility check failed. This does not block the PR because canary targets are outside the currently required support matrix. Supported peer range:
Stable Angular compatibility rows remain required and will still fail CI if the declared peer range is broken. |
osnoser1
force-pushed
the
osnoser1/ensure-angular-compatibility
branch
from
June 7, 2026 16:38
abf5bb9 to
478192d
Compare
ci: allow canary advisory pr comments refactor: extract angular canary reporter refactor: simplify canary report import
osnoser1
force-pushed
the
osnoser1/ensure-angular-compatibility
branch
from
June 7, 2026 17:18
639ba49 to
b7cdd8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #
What is the new behavior?
Adds a config-driven Angular compatibility harness for
@limitless-angular/sanitythat validates the release-shaped package, not just the monorepo source tree.The harness now:
angular-18-floor,angular-18-latest, andangular-19-latestnextcanary compatibility jobtools/angular-compat/README.mdThe command layer is centralized through
tools/angular-compat/cli.mjswithyargs, while the compatibility logic remains in reusable functions.Also fixes
SanityImageso its generated declarations remain compatible with Angular 18 consumers.Does this PR introduce a breaking change?
Other information
Validated locally with:
volta run --node 22.22.3 pnpm run compat:assertvolta run --node 22.22.3 pnpm run compat:matrixvolta run --node 22.22.3 pnpm run compat:matrix --canaryvolta run --node 22.22.3 pnpm run compat:packvolta run --node 22.22.3 pnpm run compat:artifactvolta run --node 22.22.3 pnpm run compat:release-parityvolta run --node 22.22.3 pnpm run compat:testvolta run --node 22.22.3 pnpm run compat:test --set angular-18-floor --skip-runtimevolta run --node 22.22.3 pnpm turbo run build test --affectedvolta run --node 22.22.3 pnpm turbo run lint --filter=@limitless-angular/sanityCI=1 volta run --node 22.22.3 pnpm turbo run e2e --filter=sanity-presentation-e2eCI=1 volta run --node 22.22.3 pnpm turbo run e2e-studio --filter=sanity-presentation-e2egit diff --checkCurrent PR checks are green, including
main,presentation-e2e,sanity-compat-pack, the three stable Angular consumer rows, and the advisory Angularnextrow.Changelog entries are left to the repository release script, which generates
packages/sanity/CHANGELOG.mdfrom conventional commits during release.Follow-up: #28 tracks release dry-run validation for compatibility publishing.
[Optional] What gif best describes this PR or how it makes you feel?