Repository navigation
Conversation
A presigned batch depends on remote client signatures, so an offline client can legitimately make a signing attempt time out. Treat that timeout as a retryable publish attempt instead of terminating the entire batcher and the server that runs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An offline co-signer can time out a presigned batch's signing attempt
during publication. That error currently escapes
batch.Run, terminatesBatcher.Run, and causes the Loop server supervising it to shut down andrestart.
Treat a signing deadline in presigned mode as retryable while the batch's
parent context is still active. Log it at info level and keep the batch
open so a later block can trigger another publication attempt. Other
signing errors and parent-context termination retain their existing
behavior.
Add an explanatory code comment, a release note, and a regression test
covering timeout followed by successful publication once signing recovers.
Validation:
make fmt,go test ./sweepbatcher/... -count=1, and commitmessage lint.
Pull Request Checklist
docs/release-notes/release-notes-next.md, or apply theno-changeloglabel (required by CI)