Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several native entry points assume their JavaScript arguments have the
expected type. When called with a wrong-typed value, they
abort the entire Node.js process through a failed C++ assertion or a segmentation fault.
A single bad argument from JavaScript takes down the whole process,
with no chance for a
try/catchor a rejected promise to intervene.This PR adds a type check to each affected entry point so the operation raises
a
TypeErrorinstead of crashing. Valid usage is unchanged.As an indicative example, the following code results in a hard crash.
After this change the same call rejects with a
TypeError(
fromBufferAsync: buffer must be a string or a Buffer), which the.catchhandles normally.