Conversation
Thanks!
Yep, this totally makes sense. Sadly I don't have a machine with OSX on it, so I don't think I'll be able to iterate on it here. I think it's probably best to merge this even though all of the artifacts aren't built properly so that at least we get cross-platform build validation.
Agreed. Right now the artifacts are still zipped up (this might be useful to help debugging this workflow file), but I don't expect that they'll be particularly useful to linux end-users.
When you click the down-arrow on the "merge pull-request" button, there's an option to squash commits, which uses the pull-request text as the commit message. This would be a lot easier for me (I'd rather not learn how to rewrite history in Git), so if it's cool with you, we could work on making my pull-request text a good commit message, and work from there. |
|
Oh, also, I managed to get windows actions building! |
|
ping @mkeeter |
|
Hi – I'm relatively overloaded right now, so no promises when I'll look at this! What's the purpose of changing the CMake version detection? On |
|
@mkeeter no worries! I just wanted to make sure that you saw it.
I couldn't get "bash -c" to run on windows without installing WSL, which doesn't appear to be possible on the machines that github uses to run this code. Shame about the issue though... Looks like the only use for the "bash -c" is so that you can use |
|
You can use MSYS2/Mingw64 to run bash scripts on Windows using github actions.
For example, see https://github.com/curv3d/curv/blob/master/.github/workflows/main.yml
…On Thu, Sep 17, 2020, at 10:01 PM, Ty Overby wrote:
I couldn't get "bash -c" to run on windows without installing WSL, which doesn't appear to be possible on the machines that github uses to run this code.
|
If you aren't familiar with GitHub Actions, they're a lot like other continuous-integration solutions out there.
This pull-request implements actions for building + testing + producing artifacts for Linux, OSX and windows.
There are a few things to make note of: