Sitelet https://github.com/letsar/flutter_slidable/pull/443
Skip to content

Remove deprecated apis references - #443

Merged
letsar merged 1 commit into
letsar:masterfrom
QuncCccccc:remove_deprecated_api_reference
Nov 2, 2023
Merged

letsar merged 1 commit into
letsar:masterfrom
QuncCccccc:remove_deprecated_api_reference

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Oct 26, 2023 •

Copy link
Copy Markdown
Contributor

This PR is to remove 2 references for the deprecated parameters: OutlinedButton.styleFrom.primary and OutlinedButton.styleFrom.onSurface.

It seems the request review button doesn't work here. So @letsar could you take a look? Thanks a lot:)

@Piinks

Piinks commented Nov 1, 2023

Copy link
Copy Markdown

@letsar will you accept this change?

@letsar

letsar commented Nov 2, 2023

Copy link
Copy Markdown
Owner

Yes, sorry I was not available the last week. I'll look at it as soon as possible

@letsar
letsar merged commit 5dd6ff7 into letsar:master Nov 2, 2023
@Piinks

Piinks commented Nov 2, 2023

Copy link
Copy Markdown

Thank you very much! 😁

@letsar

letsar commented Nov 2, 2023

Copy link
Copy Markdown
Owner

Published in 3.0.1 by the way

@Piinks

Piinks commented Nov 2, 2023

Copy link
Copy Markdown

@QuncCccccc ^ this is the version we will need to roll to for the affected customers. 👍

@QuncCccccc

Copy link
Copy Markdown
Contributor Author

Great! Thanks a lot @letsar @Piinks for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants