Sitelet https://github.com/letsar/flutter_slidable/pull/38
Skip to content

fix the end extend of actions in dismiss animation - #38

Merged
letsar merged 4 commits into
letsar:masterfrom
miDeb:fix_dismiss_animation
Oct 15, 2018
Merged

letsar merged 4 commits into
letsar:masterfrom
miDeb:fix_dismiss_animation

Conversation

@miDeb

@miDeb miDeb commented Oct 15, 2018

Copy link
Copy Markdown
Contributor

The end extend of secondary actions must be smaller, since their position is not at the same point as the primary action (ie. the Offset zero).

before:

dismiss_before

after:

dismiss_after

A workaround would be to wrap the ListTile with a Container and set a color.

@letsar

letsar commented Oct 15, 2018

Copy link
Copy Markdown
Owner

Hi @miDeb , thanks for this PR.
This is strange, I cannot reproduce the before use case with the current source code. But I think you're right, the end extent should be different for each actions.
Under which Flutter version are you?
Can you paste here the complete sample please, so that I can reproduce and understand before I merge this?

@letsar

letsar commented Oct 15, 2018

Copy link
Copy Markdown
Owner

Oh I think I know why. This is because I have a white background in my tiles and it's transparent in your case

@letsar
letsar merged commit ba45d60 into letsar:master Oct 15, 2018
@letsar

letsar commented Oct 15, 2018

Copy link
Copy Markdown
Owner

Published in v0.4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants