Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
When the reverse iterator cannot use the optimistic sibling jump, prev() navigates to the previous leaf using the current leaf lower fence. For a non-equal fence, lowerBound() returns the insertion position and cur is decremented once to select the correct predecessor. The fallback branch did not return afterward, so the surrounding while loop ran again and decremented cur a second time at the top of the loop. The result was the key immediately before the actual predecessor.
One reproduced case was:
The expected and returned values were adjacent in sorted order. Iterator diagnostics showed lowerBound(fence) == 98, so the first decrement selected slot 97 (the expected predecessor), while the next loop iteration incorrectly selected slot 96.
Validation