Repository navigation
Fix #17: Support clang by updating RocksDB - #25
Open
alicia-lyu wants to merge 1 commit into
Open
alicia-lyu wants to merge 1 commit into
alicia-lyu wants to merge 1 commit into
Conversation
Collaborator
|
@alicia-lyu Many thanks for your contributions. Can you also address the compile error in |
| PREFIX "vendor/rocksdb" | ||
| GIT_REPOSITORY "https://github.com/facebook/rocksdb.git" | ||
| GIT_TAG abd4b1ff1504ae2a7ed6e60bc9c9797b880c33a5 | ||
| GIT_TAG 5f003e4a22d2e48e37c98d9620241237cd30dd24 |
Collaborator
There was a problem hiding this comment.
Can you reset to the original tag?
Author
Can you include the specific error messages? |
alicia-lyu
added a commit
to alicia-lyu/leanstore
that referenced
this pull request
May 24, 2026
Refactors test_query_q10_{lsm,btree} for two improvements:
(a) Per-path Q10Stats: each of S1/S2/S3/S4 now writes into its own
fresh stats struct. Previously a single shared `s3_stats` collected
counters from all four query invocations, so e.g.
customers_scanned read 600 (= 4 × 150) instead of the actual
per-path 150. Post-S3 / post-S4 diagnostic blocks now read clean
single-path cardinalities.
(b) Off-default param re-run: after the default-param (iter=0)
4-way parity gate passes, the harness calls set_params_for_iter(1)
and re-runs all four query bodies, re-verifying strict 4-way XOR
parity at the new param set. The digest differs from iter=0 (that's
expected — different date, different qualifying rows); the gate
requires only that all four paths agree. This is the PLAYBOOK §10
anti-pattern leanstore#25/leanstore#26 guard against param-bake regressions — the
class of bug that hid Q3I's pre_revenue shipdate-bake for weeks
because its harness only used Params::defaults().
SF=1 macOS results:
iter=0 (1993-10-01): digest 0xfb1196e6072d5aef, 20 rows, all paths OK
iter=1 (1993-02-01): digest 0xe6057c38ca32a1e9, 20 rows, all paths OK
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17 by using the newest release of rocksdb. The project should be able to compile with Clang now (but one may need to add
std::toostream, etc.) Note that this commit is cherrypicked from my branch, which commented out frontend executables not using LeanStore and RocksDB. This may only solve part of the problem.