fix: change www.lua.org to lua.org to reflect certificate change - #41
Merged
Merged
Conversation
Looks like https://lua.org/ 's certificate changed today. ```text * Server certificate: * subject: CN=lua.org * start date: Dec 20 17:54:42 2023 GMT * expire date: Mar 19 17:54:41 2024 GMT * subjectAltName: host "lua.org" matched cert's "lua.org" * issuer: C=US; O=Let's Encrypt; CN=R3 * SSL certificate verify ok. ``` ```text Run leafo/gh-actions-lua@v10 with: luaVersion: 5.4 buildCache: true Notice: gh-actions-lua: No cache available, clean build Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 18 seconds before trying again Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 1[6](https://github.com/vpayno/exercism-workspace/actions/runs/7284425228/job/19849762432?pr=323#step:3:7) seconds before trying again Error: Failed to install ```
vpayno
added a commit
to vpayno/exercism-workspace
that referenced
this pull request
Dec 21, 2023
Waiting on leafo/gh-actions-lua#41 Looks like https://lua.org/ 's certificate changed today. ```text * Server certificate: * subject: CN=lua.org * start date: Dec 20 17:54:42 2023 GMT * expire date: Mar 19 17:54:41 2024 GMT * subjectAltName: host "lua.org" matched cert's "lua.org" * issuer: C=US; O=Let's Encrypt; CN=R3 * SSL certificate verify ok. ``` ```text Run leafo/gh-actions-lua@v10 with: luaVersion: 5.4 buildCache: true Notice: gh-actions-lua: No cache available, clean build Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 18 seconds before trying again Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 1[6](https://github.com/vpayno/exercism-workspace/actions/runs/7284425228/job/19849762432?pr=323#step:3:7) seconds before trying again Error: Failed to install ```
vpayno
added a commit
to vpayno/exercism-workspace
that referenced
this pull request
Dec 21, 2023
Waiting on leafo/gh-actions-lua#41 Looks like https://lua.org/ 's certificate changed today. ```text * Server certificate: * subject: CN=lua.org * start date: Dec 20 17:54:42 2023 GMT * expire date: Mar 19 17:54:41 2024 GMT * subjectAltName: host "lua.org" matched cert's "lua.org" * issuer: C=US; O=Let's Encrypt; CN=R3 * SSL certificate verify ok. ``` ```text Run leafo/gh-actions-lua@v10 with: luaVersion: 5.4 buildCache: true Notice: gh-actions-lua: No cache available, clean build Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 18 seconds before trying again Hostname/IP does not match certificate's altnames: Host: www.lua.org. is not in the cert's altnames: DNS:lua.org Waiting 1[6](https://github.com/vpayno/exercism-workspace/actions/runs/7284425228/job/19849762432?pr=323#step:3:7) seconds before trying again Error: Failed to install ```
Contributor
Author
|
Tested this fix, it works. --- a/.github/workflows/lua.yml
+++ b/.github/workflows/lua.yml
@@ -63,7 +63,7 @@ jobs:
uses: actions/checkout@v3
- name: Set up Lua
id: setup-lua
- uses: leafo/gh-actions-lua@v10
+ uses: vpayno/gh-actions-lua@fix_cert_url
with:
luaVersion: ${{ matrix.luaVersion }}
- name: Show Lua Versions |
Contributor
|
@leafo I've also loaded this change when testing the CI runs for luasystem at lunarmodules/luasystem#17 and all went well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like https://lua.org/ 's certificate changed today.