Windows support - #23
Merged
Merged
Conversation
Build manually since the provided Makefile is Unix-only. Based on similar Python code implemented by hererocks: https://github.com/luarocks/hererocks/blob/e44d384288c5385cdcfda92e662756fcd2d9eb8a/hererocks.py
alerque
approved these changes
Jul 22, 2022
Owner
|
Looks good, thanks for the contribution |
telemachus
added a commit
to telemachus/split
that referenced
this pull request
Jan 21, 2023
This should work, based on leafo/gh-actions-lua#23
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands on the work by @chipsenkbeil by adding support for PUC-Rio Lua on Windows, by launching the compiler ourselves, since the provided Makefile is pretty much Unix-only. The logic here is based on similar Python code implemented by hererocks.
The PUC-Rio Lua build is done using MSVC, while the LuaJIT build by @chipsenkbeil uses Mingw. I haven't tried building using the upstream Lua compiler with Mingw — I've personally only used it for cross-compiling from a Unix host, not sure how well that works from Windows, and I thought it would be useful to provide a MSVC-based option. To use MSVC, one needs to enable the compiler that's included in Actions's
windows-latestcontainer. Hererocks jumps through several hoops to do that, but here it was a matter of loading another Action, illamy/msvc-dev-cmd.Additional commits:
lua51.dllis installed in thebindir when deploying LuaJIT (the visible difference is that the "Test Lua" step now correctly displayshi from luaon all jobs; LuaJIT did compile on (windows support) Update to use posix path #19 and that job passed, but the output didn't show before).Closes #19.
Closes #6.