upup/pkg/fi: use literal method names for task dispatch - #18690
Merged
kubernetes-prow[bot] merged 1 commit intoAug 14, 2026
Merged
Conversation
The task engine dispatched Find, CheckChanges, ShouldCreate and the per-target Render methods via reflect method enumeration and MethodByName with variable names. The compiler marks such call sites REFLECTMETHOD, which makes the linker keep every exported method of every reachable type. Call MethodByName with string literals only: the compiler then emits R_USENAMEDMETHOD and the linker keeps just the named methods. Render dispatch probes a fixed list of renderer names; signature matching and renderer selection are unchanged. Remove reflectutils.InvokeMethod, whose string parameter reintroduced the non-constant lookup. With no other REFLECTMETHOD symbols reachable, nodeup shrinks from 46.7 MB to 31.3 MB (linux/arm64, -trimpath, -s -w). kops and kops-controller still reach text/template and need separate fixes.
Member
Author
|
/retest |
rifelpet
approved these changes
Aug 14, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task engine dispatched
Find,CheckChanges,ShouldCreateand the per-targetRender*methods via reflect method enumeration andMethodByNamewith variable names. The compiler marks such call sitesREFLECTMETHOD, which makes the linker keep every exported method of every reachable type.Call
MethodByNamewith string literals only: the compiler then emitsR_USENAMEDMETHODand the linker keeps just the named methods.Renderdispatch probes a fixed list of renderer names; signature matching and renderer selection are unchanged. Removereflectutils.InvokeMethod, whose string parameter reintroduced the non-constant lookup.With no other
REFLECTMETHODsymbols reachable, nodeup shrinks from 46.7 MB to 31.3 MB (linux/arm64,-trimpath,-s -w). kops and kops-controller still reachtext/templateand need separate fixes./cc @rifelpet @justinsb