tests/e2e: honor KOPS_EXTRA_FLAGS in the karpenter scenario - #18681
Merged
kubernetes-prow[bot] merged 1 commit intoAug 13, 2026
Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-prow[bot] merged 1 commit into
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
The karpenter scenario hardcodes CREATE_ARGS and ignores any flags the prow job supplies, so the two ipv6 variants of this job (e2e-kops-aws-ipv6-karpenter and pull-kops-e2e-aws-ipv6-karpenter) have never actually created an IPv6 cluster -- they are identical to the non-ipv6 jobs despite sitting on the kops-ipv6 dashboard. Append KOPS_EXTRA_FLAGS to CREATE_ARGS, matching how the upgrade-ab scenario already consumes it. A follow-up test-infra change switches those jobs from the OVERRIDES env var, which nothing reads, to KOPS_EXTRA_FLAGS.
rifelpet
force-pushed
the
karpenter-scenario-extra-flags
branch
from
August 12, 2026 21:58
cccd678 to
ef98d4f
Compare
rifelpet
marked this pull request as ready for review
August 12, 2026 22:07
hakman
approved these changes
Aug 13, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow Bot
pushed a commit
to kubernetes/test-infra
that referenced
this pull request
Aug 13, 2026
e2e-kops-aws-ipv6-karpenter and pull-kops-e2e-aws-ipv6-karpenter set OVERRIDES="--ipv6 --topology=private --bastion", but the karpenter scenario never reads OVERRIDES -- the only script that does is splitkcp/run-test.sh, which sets its own value locally. Both jobs have therefore been creating plain IPv4 karpenter clusters, identical to the non-ipv6 jobs, despite sitting on the kops-ipv6 dashboard. Pass the flags via extra_flags instead. That is the mechanism the scenario job path already has: build_jobs.py joins extra_flags into KOPS_EXTRA_FLAGS, which kubernetes/kops#18681 teaches the karpenter scenario to append to its create args. It also populates the test.kops.k8s.io/extra_flags annotation, so the job metadata now reflects what the job actually does. Needs kubernetes/kops#18681 to merge before these jobs exercise IPv6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/e2e/scenarios/karpenter/run-test.shbuildsCREATE_ARGSentirely from hardcoded values and never reads any flags supplied by the prow job. That makes the two IPv6 variants of this scenario a no-op:e2e-kops-aws-ipv6-karpenter(periodic, on thekops-ipv6dashboard)pull-kops-e2e-aws-ipv6-karpenter(presubmit)Both set
OVERRIDES="--ipv6 --topology=private --bastion"in their job config, but nothing in this scenario readsOVERRIDES— the only script that does issplitkcp/run-test.sh, which sets its own value locally. So both jobs have been creating plain IPv4 karpenter clusters, identical to the non-ipv6 jobs, presumably since they were added.This appends
KOPS_EXTRA_FLAGStoCREATE_ARGS, which is the variablebuild_jobs.pyalready populates from a scenario job'sextra_flagsand whichupgrade-ab/run-test.shalready consumes. Appending last means a job can also override one of the defaults above it.The companion test-infra PR, kubernetes/test-infra#37675, switches those two jobs from
OVERRIDEStoextra_flags(whichbuild_jobs.pyrenders asKOPS_EXTRA_FLAGS). Until it merges the jobs keep behaving exactly as they do today, so the two can land in either order.Testing
Verified the expansion is correct in both states:
The scenario is exercised by
pull-kops-e2e-aws-karpenterandpull-kops-e2e-aws-ipv6-karpenter. Worth noting the ipv6 presubmit will be doing real work for the first time once the test-infra side lands, so it may surface pre-existing IPv6+karpenter issues.🤖 Generated with Claude Code