Do not upload stale images. - #18665
Merged
Merged
Conversation
This makes no difference on a clean clone. However is you have been using the clone on previous releases, then you will likely have some older/stale builds. These old stale builds will then be uploaded to your storage. Fixing this is a minor optimization. It also prevents you(me) accidentily using an older build because we didn't fix our KOPS_BASE_URL path.
Member
Author
|
/assign @hakman |
Member
|
Looks great, let's ship it! 😁 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes no difference on a clean clone.
However if you have been using the clone on previous releases, then you will likely have some older/stale builds. These old stale builds will then be uploaded to your storage. Fixing this is a minor optimization.
It also prevents you(me) accidentily using an older build because we didn't fix our KOPS_BASE_URL path.