Clean up remaining gossip removal leftovers - #18658
Conversation
|
Do we validate that any k8s.local cluster must use dns=none or do we now allow k8s.local private dns zones? |
@rifelpet |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override pull-kops-e2e-k8s-aws-calico |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follow-up to #18240.
Gossip was historically inferred from a
.k8s.localcluster name. After its removal, that suffix should no longer affect runtime behavior. This change removes the shared gossip-name predicate and keeps legacy gossip detection private to API validation, where unmigrated clusters are rejected from further updates.Cloud resource discovery now consistently uses the configured DNS topology across AWS, GCE, DigitalOcean, OpenStack, and Scaleway. None-DNS clusters skip provider DNS discovery regardless of their name.
The change also removes obsolete protokube service calls from the NVIDIA hook, the no-longer-useful creation warning, and stale gossip documentation and fixture naming.
/cc @rifelpet @ameukam