Remove the protokube binary - #18653
Merged
Merged
Conversation
pkg/dns/hosts (the /etc/hosts writer used by none-DNS clusters) and pkg/etcd (etcd cluster spec parsing from volume tags) are still used outside protokube, so relocate them ahead of the protokube removal. protokube temporarily imports the new locations.
Contributor
|
Skipping CI for Draft Pull Request. |
hakman
force-pushed
the
remove-protokube
branch
2 times, most recently
from
July 30, 2026 20:51
a41760e to
f313945
Compare
hakman
marked this pull request as ready for review
July 30, 2026 20:53
protokube no longer had any responsibilities after the gossip DNS removal: nodes stopped installing and running it, and its only remaining function was serving gossip DNS. Delete the protokube tree, the forked memberlistmesh library, and the gcediscovery package whose only consumer was protokube's GCE volume provider. Remove the protokube build targets and stop publishing its release assets. The gossip well-known ports are kept (and the two dns-controller ones restored) as Deprecated constants so the port numbers are not reused. The release promotion and validation scripts learn an OPTIONAL_BINARIES mechanism, probing artifacts.k8s.io per version, so older releases that still ship protokube (and channels, dropped in kOps 1.36) keep full coverage while newer releases skip them. Only a confirmed 404 counts as absent; any other probe outcome fails the scripts.
github.com/hashicorp/memberlist and github.com/weaveworks/mesh are no longer used after the protokube removal.
rifelpet
approved these changes
Jul 30, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18601 and #18650. protokube no longer has any responsibilities: its only remaining function was gossip DNS, and nodes stopped installing and running it in kOps 1.37.
pkg/dns/hosts, and the etcd cluster spec volume-tag parsing moves topkg/etcd.protokube/tree, the forkedmemberlistmeshlibrary, and thegcediscoverypackage, whose only consumer was protokube's GCE volume provider, along with the now-unusedhashicorp/memberlistandweaveworks/meshdependencies.Deprecatedconstants inwellknownports(restoring the two dns-controller ones removed in Remove support for gossip DNS #18601) so the port numbers are not reused, and fix a long-standing 3998/3999 label swap indocs/contributing/ports.md.OPTIONAL_BINARIESmechanism that probes artifacts.k8s.io per version, so older releases keep full coverage: 1.35 and earlier validatechannelsandprotokube, 1.36 validatesprotokubeonly, and 1.37+ skips both. Only a confirmed 404 counts as absent; any other probe outcome fails the scripts, so a transient error cannot silently drop an artifact. This also fixesvalidate-github-release.shfailing against 1.35.0 over itschannelsassets.Refs: #18240