Enable nri mounting on kindnet in kops - #18635
Conversation
|
/cc @aojea |
42e1e6f to
3a22adc
Compare
| name: var-lib-kindnet | ||
| - mountPath: /var/run/nri | ||
| name: nri-plugin | ||
| - mountPath: /var/run/netns |
There was a problem hiding this comment.
this is a fall back for some previous containerd versions that didn't expose the Pod IPS on shutdown
There was a problem hiding this comment.
The netns is a fallback, should I remove that part? Don't mind either way, but might be safer to mount.
There was a problem hiding this comment.
if people use containerd < 2.1 the policies will not work fine, is safer to have since 2.0.x is still supported https://github.com/containerd/containerd/releases#release-v2.0.11 and this is exactly how we have it in the official repo
There was a problem hiding this comment.
The netns is a fallback, should I remove that part? Don't mind either way, but might be safer to mount.
I would be happier without the fallback. Thanks!
|
I'm going to release a new kindnet version with the kube-network-policies fix kubernetes-sigs/kube-network-policies#389 so we can just also update the default kindnet version in a separate commit cc: @hakman |
|
1.0.1 kindnet in its way to promotion https://github.com/kubernetes/k8s.io/pull/9777/changes , minor bugfix for kube-network policies an dependencies updates |
|
@michaelasp we can add another commit to bump the default version to kops/pkg/model/components/kindnet.go Line 39 in b587387 |
|
/lgtm modulo if we want to bump the kindnet default version |
Bumped! |
cf67bf8 to
3139e11
Compare
3139e11 to
e5e76fc
Compare
|
/lgtm |
|
Thank you both 🙂 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kindnet allows for the use of nri to enable fast local insertions of pods rather than waiting on pod informers. Enable by mounting the NRI socket into kindnet.