Sitelet https://github.com/kubernetes/kops/pull/18579
Skip to content

aws: Add metrics port 9999 to pod-identity-webhook Service - #18579

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:pod-identity-webhook-metrics-port
Jul 12, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:pod-identity-webhook-metrics-port

Conversation

@hakman

@hakman hakman commented Jul 12, 2026

Copy link
Copy Markdown
Member

The pod-identity-webhook Service is annotated with prometheus.io/port: "9999", but that port was missing from the Service spec, so Prometheus could not scrape metrics through the Service. The webhook container serves HTTP /metrics on port 9999 by default (--metrics-port), so expose that port on the Service instead of changing the annotation. Both ports are now named, as required for multi-port Services.

Fixes #15946

@kubernetes-prow
kubernetes-prow Bot requested a review from olemarkus July 12, 2026 05:45
@kubernetes-prow
kubernetes-prow Bot requested a review from zetaab July 12, 2026 05:45
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2026
The pod-identity-webhook Service is annotated with prometheus.io/port: "9999", but that port was
missing from the Service spec, so Prometheus could not scrape metrics through the Service. The
webhook container serves HTTP /metrics on port 9999 by default (--metrics-port), so expose that
port on the Service instead of changing the annotation. Both ports are now named, as required for
multi-port Services.
@hakman
hakman force-pushed the pod-identity-webhook-metrics-port branch from c2f4dbd to 9a98a2b Compare July 12, 2026 05:46
@hakman hakman changed the title eks-pod-identity-webhook: Add metrics port 9999 to Service aws: Add metrics port 9999 to pod-identity-webhook Service Jul 12, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons 9a98a2b link false /test pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit cbcd29a into kubernetes:master Jul 12, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pod-identity-webhook Prometheus port missing on service?

2 participants