pkg/assets: keep container registry clients out of runtime binaries - #18554
Merged
Merged
Conversation
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/assetsis linked intokops-controllerandnodeup, but it also carried two CLI-only pieces that pull ingo-containerregistryand, transitively,docker/cli:kops get assets --copyimage/file copy machinerycrane.Digest()call that pins images by digestThis moves the copy machinery into a new
pkg/assets/assetcopypackage (imported only by the CLI) and turns digest resolution into an injectable hook that onlycmd/kopswires up. When no resolver is set,RemapImageskips digest pinning, which already matched behavior wheneverImageDigestwas off orKOPS_BASE_URLwas set.Result:
go-containerregistryanddocker/cliare gone from thekops-controllerandnodeupbinaries and their SBOMs, so registry client CVEs (e.g. CVE-2025-15558 indocker/cli) stop showing up in scans of binaries that never talk to a registry. Binaries shrink about 1.5MB (kops-controller) and 1.2MB (nodeup)./cc @rifelpet @ameukam
Assisted by Claude Fable